Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: fix timer draining #3737

Merged
merged 1 commit into from
Dec 9, 2024
Merged

services: fix timer draining #3737

merged 1 commit into from
Dec 9, 2024

Conversation

AnnaShaleva
Copy link
Member

Ref. #3736.

Ref. #3736.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva AnnaShaleva added the bug Something isn't working label Dec 9, 2024
@AnnaShaleva AnnaShaleva added this to the v0.108.0 milestone Dec 9, 2024
@AnnaShaleva AnnaShaleva added the rpc RPC server and client label Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.83%. Comparing base (35c2c5c) to head (827acfc).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/services/rpcsrv/server.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3737      +/-   ##
==========================================
- Coverage   82.85%   82.83%   -0.02%     
==========================================
  Files         335      335              
  Lines       46848    46850       +2     
==========================================
- Hits        38814    38807       -7     
- Misses       6443     6451       +8     
- Partials     1591     1592       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roman-khimov roman-khimov merged commit 727262a into master Dec 9, 2024
32 of 34 checks passed
@roman-khimov roman-khimov deleted the fix-timer-drain branch December 9, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants