cli: make nep1X balance commands work without a wallet, fix #3275 #3659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3659 +/- ##
==========================================
+ Coverage 83.13% 83.18% +0.05%
==========================================
Files 334 334
Lines 46563 46576 +13
==========================================
+ Hits 38708 38746 +38
+ Misses 6278 6258 -20
+ Partials 1577 1572 -5 ☔ View full report in Codecov by Sentry. |
roman-khimov
force-pushed
the
make-balance-work-without-wallet
branch
3 times, most recently
from
a581fb7 to
f36b7db
Compare
AnnaShaleva
added
cli
Checking the balance should be easy without any wallets involved, the data is available anyway. Tests are extended a bit as well. Adding the command to "query nep1X" is not so trivial, so let's have it this way for now. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
make-balance-work-without-wallet
branch
from
f36b7db to
ddaf9c0
Compare
AnnaShaleva
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the balance should be easy without any wallets involved, the data is available anyway.
Adding the command to "query nep1X" is not so trivial, so let's have it this way for now.