Improve neotest to serve coverage needs #3551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods need Executor's context to properly process coverage, thus these methods are not independent anymore. Ref. #3462 (review). Signed-off-by: Anna Shaleva <[email protected]>
1. Bind NewDeployTxBy to Executor to be able to use (*Executor).AddSystemFee. 2. Replace pre-defined constant deployment fee by calculated one. This change is needed to be able to properly collect coverage for _deploy method of a contract via neotest coverage. Ref. #3462 (review). Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3551 +/- ##
==========================================
+ Coverage 86.04% 86.05% +0.01%
==========================================
Files 330 330
Lines 38674 38675 +1
==========================================
+ Hits 33276 33282 +6
+ Misses 3853 3848 -5
Partials 1545 1545 ☔ View full report in Codecov by Sentry. |
roman-khimov
reviewed
Aug 9, 2024
roman-khimov
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neotest.AddSystemFeeandneotest.TestInvoketoExecutorstate.Reasons are explained in the commit messages. @roman-khimov, these commits made in a breaking way, but if we care about our users a lot, then I can mark related methods as "deprecated" and introduce new
Executormethods in a soft way. Do we?A ground for #3462.