Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: get back default node configuration values #3504

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

AnnaShaleva
Copy link
Member

This code was accidentally removed by
#3477, it's important to have these fields set by default.

This code was accidentally removed by
#3477, it's important to have
these fields set by default.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva AnnaShaleva added bug Something isn't working I3 Minimal impact U4 Nothing urgent S4 Routine labels Jul 5, 2024
@AnnaShaleva AnnaShaleva added this to the v0.106.3 milestone Jul 5, 2024
@AnnaShaleva AnnaShaleva requested a review from roman-khimov as a code owner July 5, 2024 10:33
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.13%. Comparing base (5566e35) to head (ed9817d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3504      +/-   ##
==========================================
+ Coverage   86.11%   86.13%   +0.02%     
==========================================
  Files         331      331              
  Lines       38564    38570       +6     
==========================================
+ Hits        33209    33223      +14     
+ Misses       3825     3821       -4     
+ Partials     1530     1526       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AliceInHunterland AliceInHunterland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little bit of strange commit message formatting

@AnnaShaleva AnnaShaleva merged commit da40f2d into master Jul 5, 2024
20 of 21 checks passed
@AnnaShaleva AnnaShaleva deleted the fix-loadcfg branch July 5, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working I3 Minimal impact S4 Routine U4 Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants