actor: add a new WaitSuccess API #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
added
I3
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3491 +/- ##
==========================================
- Coverage 86.19% 86.12% -0.07%
==========================================
Files 331 331
Lines 38494 38510 +16
==========================================
- Hits 33179 33166 -13
- Misses 3785 3815 +30
+ Partials 1530 1529 -1 ☔ View full report in Codecov by Sentry. |
roman-khimov
force-pushed
the
wait-success
branch
from
b713e70 to
78d47a1
Compare
AnnaShaleva
reviewed
Jun 21, 2024
Most of the time people are interested in successful executions. Unfortunately, unwrap package can't help here because of a different result structure (some interface abstract can help, but it's still mostly stack-oriented and sessions can be a problem), so this additional interface is needed. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
wait-success
branch
from
78d47a1 to
a327a82
Compare
AnnaShaleva
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the time people are interested in successful executions. Unfortunately, unwrap package can't help here because of a different result structure (some interface abstract can help, but it's still mostly stack-oriented and sessions can be a problem), so this additional interface is needed.