config: enable Cockatrice hardfork #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
commented
May 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3446 +/- ##
=======================================
Coverage 86.12% 86.13%
=======================================
Files 331 331
Lines 38442 38442
=======================================
+ Hits 33110 33113 +3
+ Misses 3804 3801 -3
Partials 1528 1528 ☔ View full report in Codecov by Sentry. |
config/protocol.testnet.neofs.yml
Outdated
| Hardforks: | ||
| Aspidochelone: TODO | ||
| Basilisk: TODO | ||
| Cockatrice: TODO |
There was a problem hiding this comment.
This one needs to be checked. Likely can be from 0 as well.
There was a problem hiding this comment.
We have no significant (for NeoFS) changes included into this hardfork, and states change doesn't bother us in NeoFS testnet, thus setting it to 0 as well.
There was a problem hiding this comment.
We need to check compatibility anyway, but Cockatrice is not likely to be a problem, nothing significant changed for NeoFS.
Close #3434. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
force-pushed
the
enable-cockatrice
branch
from
c1ed62c to
d91a094
Compare
AnnaShaleva
added a commit
to neo-project/neo
that referenced
this pull request
May 17, 2024
Otherwise this configuration file is broken. Port changes from nspcc-dev/neo-go#3446. Signed-off-by: Anna Shaleva <[email protected]>
9 tasks
roman-khimov
approved these changes
May 17, 2024
shargon
pushed a commit
to neo-project/neo
that referenced
this pull request
May 20, 2024
Otherwise this configuration file is broken. Port changes from nspcc-dev/neo-go#3446. Signed-off-by: Anna Shaleva <[email protected]>
cschuchardt88
pushed a commit
to cschuchardt88/neo
that referenced
this pull request
Jun 11, 2024
Otherwise this configuration file is broken. Port changes from nspcc-dev/neo-go#3446. Signed-off-by: Anna Shaleva <[email protected]>
NGDAdmin
added a commit
to neo-project/neo
that referenced
this pull request
Jun 12, 2024
* [Neo Core Bug]fix 3300 (#3301) * fix 3300 * update format * add state subitems to ref counter, with suggestion from DuSmart * apply hardfork * format * my mistake * fix hardfork * remove negative check * add unit test * apply anna's suggestion --------- Co-authored-by: Shargon <[email protected]> Co-authored-by: NGD Admin <[email protected]> * SmartContract: use executing contract state to check permissions (#3290) It's not correct to use an updated contract state got from native Management to check for the allowed method call. We need to use manifest from the currently executing context for that. It may be critical for cases when executing contract is being updated firstly, and after that it calls another contract. So we need an old (executing) contract manifest for this check. This change is moved under D hardfork to avoid state diff issues on nodes update. Although it should be noted that it's hard to meet the trigger criteria. A port of nspcc-dev/neo-go#3473. This bug was discovered during the similar problem described in nspcc-dev/neo-go#3471 and fixed in nspcc-dev/neo-go#3472. I've checked all other similar usages and the rest of them use proper contract state (executing one, not the Management's one). Signed-off-by: Anna Shaleva <[email protected]> Co-authored-by: Shargon <[email protected]> Co-authored-by: Jimmy <[email protected]> Co-authored-by: Vitor Nazário Coelho <[email protected]> * v3.7.5 * Neo.CLI: enable hardforks for NeoFS mainnet (#3240) Otherwise this configuration file is broken. Port changes from nspcc-dev/neo-go#3446. Signed-off-by: Anna Shaleva <[email protected]> * fix workflow & FS config * remove hardfork for fs testnet --------- Signed-off-by: Anna Shaleva <[email protected]> Co-authored-by: Jimmy <[email protected]> Co-authored-by: Shargon <[email protected]> Co-authored-by: NGD Admin <[email protected]> Co-authored-by: Anna Shaleva <[email protected]> Co-authored-by: Vitor Nazário Coelho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3434.