Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: integrate dBFT pre-0.2.0 #3371

Merged
merged 3 commits into from
Mar 25, 2024
Merged

consensus: integrate dBFT pre-0.2.0 #3371

merged 3 commits into from
Mar 25, 2024

Conversation

AnnaShaleva
Copy link
Member

Try out unreleased version to see how the integration is going.

@AnnaShaleva AnnaShaleva added this to the v0.106.0 milestone Mar 21, 2024
@AnnaShaleva AnnaShaleva added the dependencies Dealing with project dependencies label Mar 21, 2024
@AnnaShaleva
Copy link
Member Author

Unfortunately, transactions conversion can't be handled without new list allocation.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 78.76106% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 84.78%. Comparing base (b028c77) to head (beee260).
Report is 14 commits behind head on master.

Files Patch % Lines
pkg/consensus/consensus.go 68.00% 23 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3371      +/-   ##
==========================================
- Coverage   84.82%   84.78%   -0.05%     
==========================================
  Files         331      331              
  Lines       44961    44969       +8     
==========================================
- Hits        38139    38127      -12     
- Misses       5312     5327      +15     
- Partials     1510     1515       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/core/block/header.go Outdated Show resolved Hide resolved
Try out updated dBFT interface.

Signed-off-by: Anna Shaleva <[email protected]>
Fetch fresh dbft version with minor adjustments.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva AnnaShaleva merged commit 627a0ab into master Mar 25, 2024
17 of 20 checks passed
@AnnaShaleva AnnaShaleva deleted the upd-dbft branch March 25, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dealing with project dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants