core: prohibit reentry to Notary withdraw #3357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3357 +/- ##
==========================================
+ Coverage 84.68% 84.79% +0.11%
==========================================
Files 331 331
Lines 44935 44936 +1
==========================================
+ Hits 38053 38105 +52
+ Misses 5370 5318 -52
- Partials 1512 1513 +1 ☔ View full report in Codecov by Sentry. |
|
We don't filter accounts that deposit to notary, so even though usually we assume them to be simple single-signature accounts technically contracts can deposit some GAS and play this game. Yeah, this must be fixed. |
If we're withdrawing funds to contract that has onNEP17Payment method, then it may call Notary's withdraw one more time, but the account's state is not yet updated by this moment. The problem is similar to neo-project/neo#2734. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
commented
Mar 18, 2024
|
@roman-khimov, the problem is confirmed by test, it's ready to review&merge. |
roman-khimov
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're withdrawing funds to contract that has onNEP17Payment method, then it may call Notary's withdraw one more time, but the account's state is not yet updated by this moment.
The problem is similar to neo-project/neo#2734.
@roman-khimov, if I'm not mistaken and the problem exists, then you'll be glad to see this fix. I'll create test for it.