-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpcsrv: fix TestFailedPreconditionShutdown shutdown #3335
Conversation
e924171
to
8a69486
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3335 +/- ##
=======================================
Coverage 84.87% 84.87%
=======================================
Files 328 328
Lines 44835 44835
=======================================
+ Hits 38052 38055 +3
+ Misses 5270 5268 -2
+ Partials 1513 1512 -1 ☔ View full report in Codecov by Sentry. |
hm https://github.com/nspcc-dev/neo-go/actions/runs/8144019284/job/22257197349?pr=3335#logs
|
87819c0
to
de5cb18
Compare
de5cb18
to
7e23de3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing, need to remove the following code from TestErrorResponseContentType:
defer chain.Close()
defer rpcSrv.Shutdown()
6a3038b
to
123d41a
Compare
123d41a
to
4f9a098
Compare
still problms with tcp traverse and traverseiterator on windows and mac |
Don't reference those issues that are not solved and not related to this PR then. These two are separate problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4f9a098
to
0797191
Compare
The logs race issue is a result of improper shutdown during testing. Close #3217 Signed-off-by: Ekaterina Pavlova <[email protected]>
The HTTP server should be closed at the end of the test. Signed-off-by: Ekaterina Pavlova <[email protected]>
0797191
to
ee39b5c
Compare
@roman-khimov, ready for review, you'll like this PR. |
Close #3217