rpcclient: fix address used in doc #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one doesn't really work now, it's Legacy. Replace with something N3-ish. Thanks @lock9 for reporting. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3327 +/- ##
==========================================
- Coverage 84.94% 84.94% -0.01%
==========================================
Files 328 328
Lines 44750 44754 +4
==========================================
+ Hits 38013 38016 +3
- Misses 5224 5225 +1
Partials 1513 1513 ☔ View full report in Codecov by Sentry. |
|
Hello, I think this line must be updated: |
Signed-off-by: Roman Khimov <[email protected]>
|
Huh. We have it since b2a5e34, it can't be wrong for example! |
AnnaShaleva
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one doesn't really work now, it's Legacy. Replace with something N3-ish.
Thanks @lock9 for reporting.