network: fix data race TestGetData
#3315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent "closed twice" used started atomic.Bool to ensure that the
shutdown
procedure is executed only once. `--- FAIL: TestServerRegisterPeer (0
.06s)
panic: closed twice
goroutine 60 [running]:
testing.tRunner.func1.2({0x104c40b20, 0x104d0ec90})
/opt/homebrew/opt/go/libexec/src/testing/testing.go:1545 +0x1c8
testing.tRunner.func1()
/opt/homebrew/opt/go/libexec/src/testing/testing.go:1548 +0x360
panic({0x104c40b20?, 0x104d0ec90?})
/opt/homebrew/opt/go/libexec/src/runtime/panic.go:914 +0x218
github.com/nspcc-dev/neo-go/pkg/network.(*fakeTransp).Close
(0x14000159e08?)
/Users/ekaterinapavlova/Workplace/neo-go/pkg/network
/discovery_test.go:83 +0x54
github.com/nspcc-dev/neo-go/pkg/network.(*Server).Shutdown
(0x14000343400)
/Users/ekaterinapavlova/Workplace/neo-go/pkg/network/server.go:299
+0x104
github.com/nspcc-dev/neo-go/pkg/network.startWithCleanup.func1()
/Users/ekaterinapavlova/Workplace/neo-go/pkg/network/server_test
.go:408 +0x20
testing.(*common).Cleanup.func1()
/opt/homebrew/opt/go/libexec/src/testing/testing.go:1169 +0x110
testing.(*common).runCleanup(0x1400032c340, 0x14000159d80?)
/opt/homebrew/opt/go/libexec/src/testing/testing.go:1347 +0xd8
testing.tRunner.func2()
/opt/homebrew/opt/go/libexec/src/testing/testing.go:1589 +0x2c
testing.tRunner(0x1400032c340, 0x104d0c5d0)
/opt/homebrew/opt/go/libexec/src/testing/testing.go:1601 +0x114
created by testing.(*T).Run in goroutine 1
/opt/homebrew/opt/go/libexec/src/testing/testing.go:1648 +0x33c`
Signed-off-by: Ekaterina Pavlova <[email protected]>
To prevent writing to logs after the end of the test execution concurrent registration and handshakes put to separate goroutines. Close #2973 Signed-off-by: Ekaterina Pavlova <[email protected]>
Log writing after the end of the test can be the reason of data race. Close #2974 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3315 +/- ##
==========================================
- Coverage 84.96% 84.94% -0.02%
==========================================
Files 328 328
Lines 44747 44754 +7
==========================================
- Hits 38020 38017 -3
- Misses 5216 5224 +8
- Partials 1511 1513 +2 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Feb 12, 2024
|
Closing this PR as not relevant since the logger problem will be fixed in #3307. Ref. #3307 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2974