Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: fix windows paths in VM tests #3313

Merged
merged 1 commit into from
Feb 15, 2024
Merged

config: fix windows paths in VM tests #3313

merged 1 commit into from
Feb 15, 2024

Conversation

AliceInHunterland
Copy link
Contributor

@AliceInHunterland AliceInHunterland commented Feb 11, 2024 •
edited
Loading

Close #3309

@codecov Codecov
Copy link

codecov bot commented Feb 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (939631c) 84.87% compared to head (588e911) 84.95%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3313      +/-   ##
==========================================
+ Coverage   84.87%   84.95%   +0.08%     
==========================================
  Files         328      328              
  Lines       44747    44747              
==========================================
+ Hits        37979    38015      +36     
+ Misses       5258     5219      -39     
- Partials     1510     1513       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AnnaShaleva
AnnaShaleva reviewed Feb 12, 2024
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust PR title, the title should tell us what's happening in this PR, so at least it's an action. What is "windows path in config in cli tests"?

cli/server/server_test.go Outdated Show resolved Hide resolved
cli/vm/cli_test.go Outdated Show resolved Hide resolved
@AliceInHunterland AliceInHunterland changed the title config: windows path in config in cli tests config: fix windows paths in cli tests Feb 13, 2024
@AliceInHunterland AliceInHunterland changed the title config: fix windows paths in cli tests config: fix windows paths in VM tests Feb 13, 2024
@AliceInHunterland AliceInHunterland force-pushed the TestRun_WithNewVMContextAndBreakpoints branch from a5eb45a to e8b8c6c Compare February 13, 2024 07:23
AnnaShaleva
AnnaShaleva reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need a rebase for it, otherwise LGTM.

config/protocol.unit_testnet.single.yml Show resolved Hide resolved
@AliceInHunterland
config: fix TestRun_WithNewVMContextAndBreakpoints path for windows
588e911 
Fix VM test for windows. We don't have notary enabled in unit testchains
 so it was removed.

Close #3309

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AliceInHunterland AliceInHunterland force-pushed the TestRun_WithNewVMContextAndBreakpoints branch from e8b8c6c to 588e911 Compare February 14, 2024 10:22
@AnnaShaleva AnnaShaleva merged commit 71fb759 into master Feb 15, 2024
16 of 19 checks passed
@AnnaShaleva AnnaShaleva deleted the TestRun_WithNewVMContextAndBreakpoints branch February 15, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestRun_WithNewVMContextAndBreakpoints windows path problem
2 participants
@AliceInHunterland @AnnaShaleva