config: update validation with check committee #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3294 +/- ##
==========================================
- Coverage 85.22% 85.22% -0.01%
==========================================
Files 327 327
Lines 44445 44448 +3
==========================================
+ Hits 37878 37879 +1
- Misses 5063 5064 +1
- Partials 1504 1505 +1 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Jan 18, 2024
AliceInHunterland
force-pushed
the
config-validation
branch
from
e8fc328 to
91be7b8
Compare
AnnaShaleva
reviewed
Jan 19, 2024
AliceInHunterland
force-pushed
the
config-validation
branch
from
91be7b8 to
2a02861
Compare
AnnaShaleva
reviewed
Jan 22, 2024
ProtocolConfiguration section must include stand by committee and the number of validators or committee/validators history. Close #3247 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
config-validation
branch
from
2a02861 to
5f745df
Compare
AnnaShaleva
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3247.