Move NativeUpdateHistory logic uner hardforks #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3212 +/- ##
==========================================
- Coverage 85.41% 85.25% -0.16%
==========================================
Files 326 326
Lines 43819 43831 +12
==========================================
- Hits 37427 37370 -57
- Misses 4920 4983 +63
- Partials 1472 1478 +6 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
force-pushed
the
drop-history
branch
2 times, most recently
from
6d4a64d to
9762af6
Compare
Close #3196. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
force-pushed
the
drop-history
branch
from
9762af6 to
58102a9
Compare
roman-khimov
approved these changes
Nov 21, 2023
AnnaShaleva
added a commit
that referenced
this pull request
Nov 29, 2023
Although it doesn't rais an exception on our side, we still have this unrelevant information in the resulting RPC call response structure. This should be a part of #3212. Port neo-project/neo-modules#851. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
added a commit
that referenced
this pull request
Nov 29, 2023
Although it doesn't raise an exception on our side, we still have this unrelevant information in the resulting RPC call response structure. This should be a part of #3212. Port neo-project/neo-modules#851. Signed-off-by: Anna Shaleva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3196.
Depends on #3211, draft until #3211 is merged.