Fancy service restart #2612
Merged
Fancy service restart #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProtocolConfiguration must remain the same, any errors mean that the signal will be ignored.
Most of the settings can't be changed, only services can.
Also fix addresses if needed and store this new configuration.
roman-khimov
force-pushed
the
fancy-service-restart
branch
from
8b97407 to
09ffed8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2612 +/- ##
==========================================
- Coverage 84.51% 84.35% -0.17%
==========================================
Files 299 300 +1
Lines 37882 38073 +191
==========================================
+ Hits 32016 32115 +99
- Misses 4458 4547 +89
- Partials 1408 1411 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. |
roman-khimov
force-pushed
the
fancy-service-restart
branch
from
c5dc439 to
6a85a63
Compare
fyrchik
reviewed
Jul 28, 2022
Comment on lines
+537
to
+540
| orc, _ := o.Module.Load().(*OracleService) | ||
| if orc == nil || *orc == nil { |
There was a problem hiding this comment.
Can we have a race condition, where all oracle services are restarted simultaneously and some requests are skipped?
There was a problem hiding this comment.
Probably. The only way to solve it is to fetch currently active requests on service start, I'll take a look at it.
There was a problem hiding this comment.
It's the same problem for all currently active requests before node start now, they'll be completely ignored.
Or not exactly, it's way more involved.
|
OK, this can wait for 0.98.2, too many things touched and too many open questions. |
The only thing rpcsrv needs is AddResponse callback.
Which allows to enable/disable the service, change nodes, keys and other settings. Unfortunately, atomic.Value doesn't allow Store(nil), so we have to store a pointer there that can point to nil interface.
roman-khimov
force-pushed
the
fancy-service-restart
branch
from
6a85a63 to
ad22ef6
Compare
AnnaShaleva
reviewed
Aug 2, 2022
It's a bit special since it's _always_ present to catch stateroots from the network.
Fix #1949. Also drop wallet from the ServerConfig since it's not used in any meaningful way after this change.
Now that services can come and go we need to protect all of the associated fields and allow to deregister them.
It has a stub for SIGHUP, but doesn't have anything for USR1 and USR2: Error: cli\server\server.go:520:31: undefined: syscall.SIGUSR1 Error: cli\server\server.go:521:31: undefined: syscall.SIGUSR2 Error: cli\server\server.go:565:17: undefined: syscall.SIGUSR1 Error: cli\server\server.go:608:17: undefined: syscall.SIGUSR2
Just log the error.
Move category definition from consensus to payload, consensus service is the one of its kind (HP), so network.Server can be adjusted accordingly.
roman-khimov
force-pushed
the
fancy-service-restart
branch
from
ad22ef6 to
9b0ea2c
Compare
AnnaShaleva
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1949. It works like this:
No config changes:
Enabled/disabled services: