New query commands #2090
Merged
New query commands #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2090 +/- ##
==========================================
- Coverage 84.21% 84.17% -0.04%
==========================================
Files 288 288
Lines 26911 26988 +77
==========================================
+ Hits 22662 22717 +55
- Misses 3019 3032 +13
- Partials 1230 1239 +9
Continue to review full report at Codecov.
|
AnnaShaleva
reviewed
Jul 22, 2021
This command has nothing to do with wallets.
People vote for keys, not addresses.
This:
Voted: null
Amount : 0
Block: 0
is better than this:
failed to convert account state from stackitem: invalid stackitem length
C#:
"result" : {
"localrootindex" : 11623,
"validatedrootindex" : 11623
}
Go:
"result" : {
"blockHeight" : 11627,
"stateHeight" : 11627
}
roman-khimov
force-pushed
the
new-query-commands
branch
2 times, most recently
from
2fd22d7 to
5f82c0d
Compare
AnnaShaleva
requested changes
Jul 23, 2021
roman-khimov
force-pushed
the
new-query-commands
branch
from
5f82c0d to
8b0dfe1
Compare
AnnaShaleva
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add a bit more, but we need this now.