Fix oracle service behaviour #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an oracle node is resynchronized from the genesis the service receives all requests from all blocks via AddRequests() invoked from the native contract. Almost all of them are long obsolete and need to be removed, native oracle contract will try to do that with RemoveRequests() calls, but they won't change anything. So queue up all "initial" requests in special map and manage it directly before the module is Run() which happens after synchronization completion. Then process any requests that are still active and work with new blocks as usual.
roman-khimov
force-pushed
the
fix-oracle-service-behaviour
branch
from
c2e87a5 to
3a93977
Compare
Codecov Report
@@ Coverage Diff @@
## master #2074 +/- ##
==========================================
+ Coverage 84.19% 84.20% +0.01%
==========================================
Files 287 287
Lines 26860 26884 +24
==========================================
+ Hits 22616 22639 +23
Misses 3017 3017
- Partials 1227 1228 +1
Continue to review full report at Codecov.
|
fyrchik
approved these changes
Jul 20, 2021
AnnaShaleva
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have many of the problems neo-project/neo-modules#608 fixes, but we have one of our own.