Add System.Runtime.GetRandom
#2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2066 +/- ##
==========================================
+ Coverage 84.19% 84.28% +0.08%
==========================================
Files 287 287
Lines 26798 26841 +43
==========================================
+ Hits 22562 22622 +60
+ Misses 3012 2991 -21
- Partials 1224 1228 +4
Continue to review full report at Codecov.
|
AnnaShaleva
requested changes
Jul 15, 2021
AnnaShaleva
requested changes
Jul 15, 2021
AnnaShaleva
approved these changes
Jul 15, 2021
Signed-off-by: Evgeniy Stratonikov <[email protected]>
Signed-off-by: Evgeniy Stratonikov <[email protected]>
Signed-off-by: Evgeniy Stratonikov <[email protected]>
Our murmur3 implementation is architecture independent and optimized in assembly. Signed-off-by: Evgeniy Stratonikov <[email protected]>
Signed-off-by: Evgeniy Stratonikov <[email protected]>
|
So have you tested it in mixed consensus setup? |
|
@roman-khimov yes, works as expected https://github.com/nspcc-dev/neo-bench/tree/rc3-update, will make a PR in bench after merge. |
roman-khimov
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2062 .
Need to wait until neo-project/neo#2541 resolves.
Testing:
make env_upworks and accepts blocks.