Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune fixed GAS limits #2055

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Tune fixed GAS limits #2055

merged 2 commits into from
Jul 16, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Jul 12, 2021

Close #2037 .

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #2055 (2cd5b63) into master (1853d0c) will increase coverage by 1.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2055      +/-   ##
==========================================
+ Coverage   83.15%   84.54%   +1.39%     
==========================================
  Files         287      287              
  Lines       23419    27482    +4063     
==========================================
+ Hits        19473    23235    +3762     
- Misses       2736     3012     +276     
- Partials     1210     1235      +25     
Impacted Files Coverage Δ
pkg/core/native/policy.go 88.14% <ø> (+1.51%) ⬆️
pkg/core/stateroot/module.go 83.56% <ø> (+2.91%) ⬆️
pkg/network/extpool/pool.go 100.00% <ø> (ø)
pkg/core/blockchain.go 81.23% <100.00%> (+2.25%) ⬆️
pkg/vm/exception.go 38.46% <0.00%> (-11.54%) ⬇️
pkg/vm/context.go 87.09% <0.00%> (-3.82%) ⬇️
cli/main.go 75.00% <0.00%> (-3.58%) ⬇️
pkg/consensus/prepare_request.go 80.00% <0.00%> (-3.34%) ⬇️
pkg/rpc/response/errors.go 84.00% <0.00%> (-2.67%) ⬇️
cli/util/convert.go 70.00% <0.00%> (-2.23%) ⬇️
... and 281 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1853d0c...2cd5b63. Read the comment docs.

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that headers have 3_00000000L limit.

pkg/core/blockchain.go Outdated Show resolved Hide resolved
@fyrchik
Copy link
Contributor Author

fyrchik commented Jul 13, 2021

While we decode CMDHeaders payload, we don't use it in any way. It is added in #2019 though.

@AnnaShaleva
Copy link
Member

While we decode CMDHeaders payload, we don't use it in any way. It is added in #2019 though.

So I can fix it in #2019 then.

@roman-khimov
Copy link
Member

roman-khimov commented Jul 13, 2021

I'd rather have it here (it's quite a simple change that technically has nothing to do with the essence of #2019). #2019 might be postponed after 0.96.0.

fyrchik added 2 commits July 14, 2021 10:27
Signed-off-by: Evgeniy Stratonikov <[email protected]>
Signed-off-by: Evgeniy Stratonikov <[email protected]>
@roman-khimov
Copy link
Member

@fyrchik?

@fyrchik
Copy link
Contributor Author

fyrchik commented Jul 16, 2021

Sorry, forgot to push changes.

@roman-khimov roman-khimov requested a review from AnnaShaleva July 16, 2021 12:34
@roman-khimov roman-khimov merged commit 21e05f5 into master Jul 16, 2021
@roman-khimov roman-khimov deleted the fix-gas-limits branch July 16, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tune fixed GAS limits
3 participants