Check manifest permissions at compile-time #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2025 +/- ##
=======================================
Coverage 83.14% 83.15%
=======================================
Files 287 287
Lines 23250 23295 +45
=======================================
+ Hits 19331 19370 +39
- Misses 2719 2723 +4
- Partials 1200 1202 +2
Continue to review full report at Codecov.
|
AnnaShaleva
requested changes
Jun 28, 2021
On many occassions we can determine at compile-time if contract config lacks some properties it needs. This includes all native contract invocations through stdlib, as both hashes and methods are known at compile-time there. Signed-off-by: Evgeniy Stratonikov <[email protected]>
If a method is known at compile time we can still check if it is present in the list of methods of at least one contract. Signed-off-by: Evgeniy Stratonikov <[email protected]>
For `nft-nd-nns` example only `namestate.go` file was compiled which is certainly not what we want. Signed-off-by: Evgeniy Stratonikov <[email protected]>
AnnaShaleva
approved these changes
Jun 28, 2021
roman-khimov
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do our best.
Close #2022.