core: fix the way candidates are sorted #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(*NEO).GetCandidates along with getCandidatesCall use candidates sorted by serialized ECPoint bytes. (*NEO).computeCommitteeMembers use candidates sorted by votes, and then by deserialized ECPoint, i.e. using default ECPoint comparator.
roman-khimov
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
State diff at block 151376 due to invalid order of candidates returned from native NEO
getCandidatescall.Solution
(*NEO).GetCandidates along with getCandidatesCall use candidates sorted
by serialized ECPoint bytes. See ref. GetCandidates and Seek.
(*NEO).computeCommitteeMembers use candidates sorted by votes, and then
by deserialized ECPoint, i.e. using default ECPoint comparator. See ref. ComputeCommetteeMembers and CompareTo.
This issue was partially fixed in #1639.
Closes #2015. Makes us compatible up to 156K of the RC3 testnet.