Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: allow to specify CustomContracts/Groups signer #1973

Merged
merged 1 commit into from
May 28, 2021
Merged

cli: allow to specify CustomContracts/Groups signer #1973

merged 1 commit into from
May 28, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented May 24, 2021

The syntax is CalledByEntry,CustomContracts:hash1:hash2.

This way we need to perform validation (don't combine Global with other scopes separately).
Another solution is CalledByEntry,CustomContracts,CustomGroups:hash1:hash2:key1:key2 but it is non-intuitive.

@roman-khimov
Copy link
Member

Technically there can be any combination of CalledByEntry, CustomContracts and CustomGroups in a single signer entry.

@roman-khimov
Copy link
Member

roman-khimov commented May 25, 2021 •
edited
Loading

IIUC it's gonna be like CalledByEntry,CustomContracts:hash1:hash2,CustomGroups:key1:key2, I can't say I really like it but if it works it should be sufficient.

AnnaShaleva
AnnaShaleva reviewed May 28, 2021
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a command usage text update for this pretty extension, otherwise looks good to me.

roman-khimov
roman-khimov reviewed May 28, 2021
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And yes, we need to document it.

cli/cmdargs/parser.go Outdated Show resolved Hide resolved
cli/cmdargs/parser.go Show resolved Hide resolved
cli/cmdargs/parser.go Show resolved Hide resolved
cli/cmdargs/parser.go Outdated Show resolved Hide resolved
@fyrchik
cli: allow to specify CustomContracts/Groups signer
e3e0e2a 
The syntax is `CalledByEntry,CustomContracts:hash1:hash2`.
@roman-khimov roman-khimov merged commit 1a16068 into master May 28, 2021
@roman-khimov roman-khimov deleted the custom-contracts branch May 28, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fyrchik @roman-khimov @AnnaShaleva