Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: make MaxValidUntilBlockIncrement configurable #1963

Merged
merged 1 commit into from
May 17, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented May 17, 2021

Close #1962 .

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #1963 (33e1e61) into master (2cb878c) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1963      +/-   ##
==========================================
+ Coverage   83.00%   83.08%   +0.07%     
==========================================
  Files         289      289              
  Lines       23667    23673       +6     
==========================================
+ Hits        19645    19668      +23     
+ Misses       2790     2770      -20     
- Partials     1232     1235       +3     
Impacted Files Coverage Δ
pkg/core/transaction/transaction.go 88.23% <ø> (ø)
pkg/core/blockchain.go 80.08% <100.00%> (+0.10%) ⬆️
pkg/core/native/notary.go 86.58% <100.00%> (+0.05%) ⬆️
pkg/services/oracle/response.go 85.22% <100.00%> (ø)
pkg/network/server.go 70.90% <0.00%> (+0.14%) ⬆️
pkg/services/oracle/request.go 52.41% <0.00%> (+4.13%) ⬆️
pkg/services/oracle/oracle.go 90.90% <0.00%> (+11.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb878c...33e1e61. Read the comment docs.

@roman-khimov roman-khimov merged commit f0e603c into master May 17, 2021
@roman-khimov roman-khimov deleted the custom-mvubi branch May 17, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make MaxValidUntilBlockIncrement configurable
3 participants