Single stateroot sender #1953
Merged
Single stateroot sender #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're modifying it here, so there can be a race between this method and AddSignature().
Makes more sense because it's not just roots that we're relaying.
And don't add/resend it multiple times. 1. We can be in a setup with one SV only and no AddSignature() called at all. 2. AddSignature() might add M-1 signatures and our signature should be the last one to complete MPTRoot, but we'll never do that.
fyrchik
reviewed
May 7, 2021
| _ = time.AfterFunc(delay, func() { | ||
| s.sendVote(ir) | ||
| }) | ||
| ir.retries++ |
There was a problem hiding this comment.
The mutex is taken on read only.
pkg/services/stateroot/service.go
Outdated
| ir.isSent = true | ||
| ir.Unlock() | ||
| } | ||
| s.srMtx.Unlock() |
There was a problem hiding this comment.
Can we move this unlock before the if?
These are arbitrary numbers, but that's what C# node uses. maxRetries could be set lower because we have exponential backoff anyway, but this works too.
Drop old incomplete roots from the map.
roman-khimov
force-pushed
the
single-stateroot-sender
branch
from
a10ee0d to
3957174
Compare
fyrchik
approved these changes
May 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #1953 +/- ##
==========================================
+ Coverage 82.71% 82.77% +0.06%
==========================================
Files 290 290
Lines 23328 23371 +43
==========================================
+ Hits 19295 19345 +50
+ Misses 2803 2790 -13
- Partials 1230 1236 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#1922 originally, but some additional fixes were also needed.