Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Itoa/Atoi overloads, add string-related methods to Std contract #1943

Merged
merged 5 commits into from
May 11, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Apr 30, 2021

Close #1928 .

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #1943 (40d1dd0) into master (a4b54b2) will increase coverage by 0.07%.
The diff coverage is 83.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1943      +/-   ##
==========================================
+ Coverage   82.68%   82.76%   +0.07%     
==========================================
  Files         290      290              
  Lines       23377    23489     +112     
==========================================
+ Hits        19330    19440     +110     
+ Misses       2813     2811       -2     
- Partials     1234     1238       +4     
Impacted Files Coverage Δ
pkg/interop/native/std/std.go 0.00% <0.00%> (ø)
pkg/core/native/std.go 96.65% <94.73%> (+0.84%) ⬆️
pkg/consensus/consensus.go 70.21% <0.00%> (-0.61%) ⬇️
pkg/services/oracle/request.go 52.41% <0.00%> (+5.51%) ⬆️
pkg/services/oracle/oracle.go 90.90% <0.00%> (+11.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b54b2...40d1dd0. Read the comment docs.

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little worried about the interop interface we provide, we don't have overloading, thus it starts to look strange.

pkg/interop/native/std/std.go Show resolved Hide resolved
pkg/interop/native/std/std.go Outdated Show resolved Hide resolved
pkg/interop/native/std/std.go Outdated Show resolved Hide resolved
pkg/interop/native/std/std.go Outdated Show resolved Hide resolved
pkg/interop/native/std/std.go Outdated Show resolved Hide resolved
@roman-khimov roman-khimov merged commit c47fb67 into master May 11, 2021
@roman-khimov roman-khimov deleted the itoa-overload branch May 11, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Itoa/Atoi overloads and memory/string stdlib methods
3 participants