Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: add ability to specify port for P2P version exchange #1942

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

AnnaShaleva
Copy link
Member

Close #1868

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #1942 (09bb162) into master (5924123) will increase coverage by 0.06%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1942      +/-   ##
==========================================
+ Coverage   82.92%   82.98%   +0.06%     
==========================================
  Files         289      289              
  Lines       22883    22960      +77     
==========================================
+ Hits        18975    19054      +79     
+ Misses       2713     2705       -8     
- Partials     1195     1201       +6     
Impacted Files Coverage Δ
pkg/network/server.go 70.58% <0.00%> (-0.21%) ⬇️
pkg/network/server_config.go 100.00% <100.00%> (ø)
pkg/core/interops.go 100.00% <0.00%> (ø)
pkg/interop/native/gas/gas.go 0.00% <0.00%> (ø)
pkg/interop/runtime/runtime.go 0.00% <0.00%> (ø)
pkg/core/interop/runtime/engine.go 100.00% <0.00%> (ø)
pkg/services/notary/notary.go 92.46% <0.00%> (+1.00%) ⬆️
pkg/services/oracle/request.go 53.23% <0.00%> (+5.75%) ⬆️
pkg/core/native/native_gas.go 77.01% <0.00%> (+8.38%) ⬆️
pkg/services/oracle/oracle.go 90.90% <0.00%> (+11.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5924123...09bb162. Read the comment docs.

@roman-khimov roman-khimov merged commit 8bfb6d7 into master Apr 30, 2021
@roman-khimov roman-khimov deleted the server/announced_port branch April 30, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let node announce address other than the one it's bound to
3 participants