Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: unify 'contract deploy' and 'contract invoke*' #1915

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

AnnaShaleva
Copy link
Member

Close #1887

Depends on #1914

@roman-khimov
Copy link
Member

Rebase, please.

@AnnaShaleva AnnaShaleva force-pushed the cli/deploy_refactoring branch 2 times, most recently from 6293b2b to 5b73abb Compare April 23, 2021 08:12
@roman-khimov
Copy link
Member

I also don't really like returning sender from invokeWithArgs, but looks like it's not easy to avoid this at the moment.

@AnnaShaleva AnnaShaleva force-pushed the cli/deploy_refactoring branch from 5b73abb to 76de4b9 Compare April 23, 2021 09:38
@AnnaShaleva AnnaShaleva force-pushed the cli/deploy_refactoring branch from 76de4b9 to e48eb10 Compare April 23, 2021 09:40
@AnnaShaleva
Copy link
Member Author

I also don't really like returning sender from invokeWithArgs, but looks like it's not easy to avoid this at the moment.

The other option is to get the sender from context, but this will result in getAccFromContext's code duplication.

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #1915 (76de4b9) into master (402cd2a) will increase coverage by 0.10%.
The diff coverage is 80.00%.

❗ Current head 76de4b9 differs from pull request most recent head e48eb10. Consider uploading reports for the commit e48eb10 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1915      +/-   ##
==========================================
+ Coverage   82.89%   82.99%   +0.10%     
==========================================
  Files         289      289              
  Lines       22872    22856      -16     
==========================================
+ Hits        18959    18970      +11     
+ Misses       2717     2690      -27     
  Partials     1196     1196              
Impacted Files Coverage Δ
cli/smartcontract/smart_contract.go 87.09% <80.00%> (+1.64%) ⬆️
pkg/services/oracle/request.go 53.23% <0.00%> (+4.31%) ⬆️
pkg/services/oracle/oracle.go 90.90% <0.00%> (+11.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 402cd2a...e48eb10. Read the comment docs.

@roman-khimov roman-khimov merged commit b0e8e37 into master Apr 23, 2021
@roman-khimov roman-khimov deleted the cli/deploy_refactoring branch April 23, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify contract deployment and function invocation code
2 participants