cli: allow to pass 'data' for nep17 transfer command #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a part of transfer, thus it should be passed along with the other transfer parameters.
We need this for tests.
It'll help to convert Parameter to a atandard type which then can be emitted ass an array item.
Codecov Report
@@ Coverage Diff @@
## master #1906 +/- ##
==========================================
+ Coverage 82.81% 83.03% +0.22%
==========================================
Files 287 287
Lines 22782 23118 +336
==========================================
+ Hits 18866 19197 +331
+ Misses 2721 2692 -29
- Partials 1195 1229 +34
Continue to review full report at Codecov.
|
AnnaShaleva
force-pushed
the
cli/transfer_param
branch
from
20097c5 to
4e468b8
Compare
AnnaShaleva
force-pushed
the
cli/transfer_param
branch
from
4e468b8 to
db868f0
Compare
roman-khimov
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1896.
Implemented only for single transfer, because multitransfer syntax doesn't allow to easily parse data for each token. However, we may add an ability to provide one common data parameter for all multitransfer tokens via the last argument.