rpc/server: be more specific in some sendrawtransaction error cases #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
reviewed
Apr 10, 2021
| @@ -1419,15 +1419,15 @@ func (s *Server) submitOracleResponse(ps request.Params) (interface{}, *response | |||
|
|
|||
| func (s *Server) sendrawtransaction(reqParams request.Params) (interface{}, *response.Error) { | |||
| if len(reqParams) < 1 { | |||
| return nil, response.ErrInvalidParams | |||
| return nil, response.NewInvalidParamsError("not enough parameters", nil) | |||
There was a problem hiding this comment.
Then maybe we can do the same thing for submitNotaryRequest and submitBlock RPC methods?
There was a problem hiding this comment.
Makes sense, updated. In general we're already better than C# node with error responses for things like verification failures (thanks to 94430ef), but these decoding/parameter errors need an improvement.
Codecov Report
@@ Coverage Diff @@
## master #1899 +/- ##
==========================================
+ Coverage 82.81% 82.89% +0.07%
==========================================
Files 287 287
Lines 22780 22780
==========================================
+ Hits 18866 18884 +18
+ Misses 2719 2697 -22
- Partials 1195 1199 +4
Continue to review full report at Codecov.
|
AnnaShaleva
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs. #1894.