core: RC1 states dumps compatibility fixes #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1869 +/- ##
==========================================
- Coverage 83.10% 83.05% -0.06%
==========================================
Files 286 286
Lines 22649 22661 +12
==========================================
- Hits 18823 18820 -3
- Misses 2641 2654 +13
- Partials 1185 1187 +2
Continue to review full report at Codecov.
|
C# node returns an error if the candidate is not registered. We have this check inside the ModifyAccountVotes, but (*NEO).vote doesn't panics and just return bool on stack, so we should match exactly the C#'s algorithm.
After getting account from the storage there are a lot of checks which may fail. But C# node uses Snapshot.GetAndChange, so the account state should be put in the storage even in case of vote failure. Affects dumps.
C# node uses Snapshot.GetAndChange to get it from storage, so it's the same problem as with voting account. Affects dumps.
AnnaShaleva
force-pushed
the
testnet-storage-fixes
branch
from
2e44b23 to
b7194ec
Compare
roman-khimov
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
States diffs.