Fix broken stateroots #1866
Merged
Fix broken stateroots #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it's a part of the header.
It was completely ruined by bf20db0. MPT was updating bc.dao directly which shouldn't ever happen, it must write into the same cache and then Persist these KVs as usual.
Prevent
2021-03-27T00:05:23.382+0300 WARN blockQueue: failed adding block into the blockchain {"error": "error while trying to apply MPT changes: key not found", "blockHeight": 12757, "nextIndex": 12758}
after node restart (node reads "local" root hash that it doesn't have).
It's a local problem and returning error from here leads to peer disconnect that isn't solving anything.
Codecov Report
@@ Coverage Diff @@
## master #1866 +/- ##
==========================================
+ Coverage 83.31% 83.41% +0.09%
==========================================
Files 283 283
Lines 22467 22476 +9
==========================================
+ Hits 18719 18748 +29
+ Misses 2592 2569 -23
- Partials 1156 1159 +3
Continue to review full report at Codecov.
|
AnnaShaleva
approved these changes
Mar 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
They're broken.
Solution
Make them a little less broken.