examples: update owner address #1854
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1854 +/- ##
==========================================
+ Coverage 83.31% 83.59% +0.27%
==========================================
Files 283 283
Lines 22475 23104 +629
==========================================
+ Hits 18726 19314 +588
+ Misses 2595 2593 -2
- Partials 1154 1197 +43
Continue to review full report at Codecov.
|
|
I think we either need to put this wallet into the repo or at least give some hint on where it can be found. |
I think the first option is better, fixed. |
| @@ -475,6 +475,9 @@ func TestCompileExamples(t *testing.T) { | |||
| e := newExecutor(t, false) | |||
|
|
|||
| for _, info := range infos { | |||
| if !info.IsDir() { | |||
There was a problem hiding this comment.
Quite radical. Though fine if explained.
examples/my_wallet.json
Outdated
| @@ -0,0 +1 @@ | |||
| {"version":"3.0","accounts":[{"address":"NX1yL5wDx3inK2qUVLRVaqCLUxYnAbv85S","key":"6PYUz1rNSwDf9ad1vxYbJyK93GrnnPBhr819HgSefMvgU1H9QxqVVCZQtN","label":"my_account","contract":{"script":"DCEDhEhWuuSSNuCc7nLsxQhI8nFlt+UfY3oP0/UkYmdH7G5BdHR2qg==","parameters":[{"name":"parameter0","type":"Signature"}],"deployed":false},"lock":false,"isdefault":false}],"scrypt":{"n":16384,"r":8,"p":8},"extra":{"Tokens":null}} | |||
There was a problem hiding this comment.
If we're putting this into examples, it should be explained somehow (and the test as well). Previously it was kinda obvious (although not quite for everyone) that we only have subdirectories in examples and each of them is an example of its own. Now this file is added to examples along with some .go file, so as a user I'm not sure where to start with all of this. Let's create a README here (in examples) with very brief introduction to examples and other things we have (and link this README from top-level one).
There was a problem hiding this comment.
I wrote a README and moved the test to the pkg/wallet because this dev-related code inside the examples folder may floor the user.
AnnaShaleva
force-pushed
the
examples/fix-owner
branch
from
8a76a7f to
3a355de
Compare
AnnaShaleva
force-pushed
the
examples/fix-owner
branch
from
3a355de to
5bd0b10
Compare
And provide the wallet for examples `my_wallet.json` with the owner address inside.
AnnaShaleva
force-pushed
the
examples/fix-owner
branch
from
5bd0b10 to
0948d53
Compare
Update to the new valid one after the signature scheme changes.