Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: refactor Rubl test contract #1852

Merged
merged 3 commits into from
Mar 22, 2021
Merged

rpc: refactor Rubl test contract #1852

merged 3 commits into from
Mar 22, 2021

Conversation

AnnaShaleva
Copy link
Member

No description provided.

@AnnaShaleva
rpc: refactor (*Client).AddNetworkFee errors handling
ee76db9 
core.ErrVerificationFailed is not very informative. Also removing it
from RPC client allows to get rid of `core` dependency in the `client`
package, which is needed for the next commit.
@codecov
Copy link

codecov bot commented Mar 22, 2021 •
edited
Loading

Codecov Report

Merging #1852 (6b36590) into master (a727ba7) will increase coverage by 0.07%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1852      +/-   ##
==========================================
+ Coverage   83.32%   83.40%   +0.07%     
==========================================
  Files         283      283              
  Lines       22473    22475       +2     
==========================================
+ Hits        18726    18745      +19     
+ Misses       2594     2574      -20     
- Partials     1153     1156       +3
Impacted Files Coverage Δ
pkg/rpc/client/rpc.go 83.82% <50.00%> (-0.39%) ⬇️
cli/smartcontract/smart_contract.go 87.88% <100.00%> (ø)
pkg/network/server.go 71.40% <0.00%> (+0.14%) ⬆️
pkg/services/notary/notary.go 92.38% <0.00%> (+1.01%) ⬆️
pkg/services/oracle/request.go 55.64% <0.00%> (+4.83%) ⬆️
pkg/services/oracle/oracle.go 90.58% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a727ba7...6b36590. Read the comment docs.

@roman-khimov roman-khimov added this to the v0.94.1 milestone Mar 22, 2021
roman-khimov
roman-khimov requested changes Mar 22, 2021
View reviewed changes
pkg/core/helper_test.go Show resolved Hide resolved
pkg/rpc/server/testdata/test_contract.go Outdated Show resolved Hide resolved
pkg/rpc/server/testdata/test_contract.go Outdated Show resolved Hide resolved
pkg/rpc/server/testdata/test_contract.yml Outdated Show resolved Hide resolved
@AnnaShaleva AnnaShaleva force-pushed the tests/fix-rubles-contract branch from f2029d6 to 6b36590 Compare March 22, 2021 12:36
@roman-khimov roman-khimov merged commit 28da00f into master Mar 22, 2021
@roman-khimov roman-khimov deleted the tests/fix-rubles-contract branch March 22, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@fyrchik fyrchik Awaiting requested review from fyrchik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.94.1
Development

Successfully merging this pull request may close these issues.
2 participants
@AnnaShaleva @roman-khimov