Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use filters with NeoFS responses #1830

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Use filters with NeoFS responses #1830

merged 2 commits into from
Mar 17, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Mar 12, 2021

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #1830 (e8b95eb) into master (508a1ca) will increase coverage by 0.21%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1830      +/-   ##
==========================================
+ Coverage   83.37%   83.58%   +0.21%     
==========================================
  Files         281      281              
  Lines       22353    22543     +190     
==========================================
+ Hits        18637    18843     +206     
+ Misses       2575     2550      -25     
- Partials     1141     1150       +9     
Impacted Files Coverage Δ
pkg/services/oracle/neofs/neofs.go 37.34% <33.33%> (+0.98%) ⬆️
pkg/services/oracle/request.go 55.64% <50.00%> (+2.61%) ⬆️
pkg/services/oracle/filter.go 86.66% <100.00%> (+8.88%) ⬆️
pkg/network/compress.go 62.50% <0.00%> (ø)
pkg/network/payload/extensible.go 100.00% <0.00%> (ø)
pkg/core/transaction/transaction.go 90.43% <0.00%> (+1.61%) ⬆️
pkg/network/payload/notary_request.go 87.12% <0.00%> (+5.54%) ⬆️
pkg/core/block/header.go 88.79% <0.00%> (+6.29%) ⬆️
pkg/smartcontract/context/context.go 90.78% <0.00%> (+8.26%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 508a1ca...e8b95eb. Read the comment docs.

@roman-khimov
Copy link
Member

1. `GetHash` returnes '0x'-prefixed little-endian hex-string.
2. `GetPayload` and `GetRange` assume result is UTF-8.
@roman-khimov roman-khimov added this to the v0.94.0 milestone Mar 16, 2021
@roman-khimov roman-khimov merged commit cb1583e into master Mar 17, 2021
@roman-khimov roman-khimov deleted the fix/neofs branch March 17, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants