native: implement StdLib and CryptoLib contracts #1824

AnnaShaleva · 2021-03-09T18:15:17Z

codecov · 2021-03-09T18:27:01Z

Codecov Report

Merging #1824 (9015e50) into master (19a23a3) will increase coverage by 0.04%.
The diff coverage is 87.74%.

@@            Coverage Diff             @@
##           master    #1824      +/-   ##
==========================================
+ Coverage   83.42%   83.46%   +0.04%     
==========================================
  Files         283      281       -2     
  Lines       22194    22271      +77     
==========================================
+ Hits        18515    18589      +74     
+ Misses       2549     2545       -4     
- Partials     1130     1137       +7

Impacted Files	Coverage Δ
pkg/core/interop/crypto/interop.go	`100.00% <ø> (ø)`
pkg/core/interops.go	`100.00% <ø> (ø)`
pkg/core/native/designate.go	`76.58% <ø> (ø)`
pkg/core/native/ledger.go	`92.92% <ø> (ø)`
pkg/core/native/name_service.go	`82.09% <ø> (ø)`
pkg/core/native/native_gas.go	`73.91% <ø> (ø)`
pkg/core/native/native_neo.go	`72.24% <ø> (ø)`
pkg/core/native/oracle.go	`76.89% <ø> (ø)`
pkg/core/native/policy.go	`86.62% <ø> (ø)`
pkg/interop/crypto/crypto.go	`0.00% <0.00%> (ø)`
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a23a3...9015e50. Read the comment docs.

fyrchik

Why are last 2 commits in this PR?

fyrchik · 2021-03-10T07:40:55Z

pkg/core/native/std.go

+	s.AddMethod(md, desc)
+
+	desc = newDescriptor("jsonSerialize", smartcontract.ByteArrayType,
+		manifest.NewParameter("data", smartcontract.AnyType))


The name is "item".

Fixed. I forgot about the names.

fyrchik · 2021-03-10T07:41:20Z

pkg/core/native/std.go

+	s.AddMethod(md, desc)
+
+	desc = newDescriptor("jsonDeserialize", smartcontract.AnyType,
+		manifest.NewParameter("data", smartcontract.ByteArrayType))


The name is "json".

fyrchik · 2021-03-10T07:44:43Z

pkg/core/native/std.go

+	s.AddMethod(md, desc)
+
+	desc = newDescriptor("base64Decode", smartcontract.ByteArrayType,
+		manifest.NewParameter("data", smartcontract.StringType))


The name is "s".

fyrchik · 2021-03-10T07:44:51Z

pkg/core/native/std.go

+	s.AddMethod(md, desc)
+
+	desc = newDescriptor("base58Decode", smartcontract.ByteArrayType,
+		manifest.NewParameter("data", smartcontract.StringType))


The name is "s".

fyrchik · 2021-03-10T07:48:07Z

pkg/core/native/std.go

+}
+
+func (s *Std) atoi(_ *interop.Context, args []stackitem.Item) stackitem.Item {
+	numBytes, err := args[0].TryBytes()


toString(args[0]) ?

Fixed here and in all other places.

fyrchik · 2021-03-10T07:48:34Z

pkg/core/native/std.go

+		panic(fmt.Errorf("invalid value stackitem: %w", err))
+	}
+	num := string(numBytes)
+	base, err := args[1].TryInteger()


toBigInt(args[1]) ?

fyrchik · 2021-03-10T07:52:50Z

pkg/compiler/inline_test.go

 		import "github.com/nspcc-dev/neo-go/pkg/compiler/testdata/inline"
 		func Main() int {
 			sum := 0
 			values := []int{10, 11}
 			for _, v := range values {
-				binary.Itoa(v, 10)


It needs to be replaced with another syscall returning some value (Notify returns nothing).

fyrchik · 2021-03-10T07:53:07Z

pkg/compiler/inline_test.go

 		import "github.com/nspcc-dev/neo-go/pkg/compiler/testdata/inline"
 		func Main() int {
 			sum := 0
 			values := []int{10, 11}
 			for _, v := range values {
-				binary.Itoa(v, 10)


fyrchik · 2021-03-10T07:54:00Z

pkg/compiler/inline_test.go

 		import "github.com/nspcc-dev/neo-go/pkg/compiler/testdata/inline"
 		func Main() int {
 			sum := 0
 			values := []int{10, 11}
 			for _, v := range values {
-				binary.Itoa(v, 10)
-				sum += inline.VarSum(1, 2, 3, binary.Atoi("4", 10))


Here we need some syscall which returns integer.

Replaced with runtime.GetTime.

fyrchik · 2021-03-10T07:54:31Z

pkg/compiler/inline_test.go

 		import "github.com/nspcc-dev/neo-go/pkg/compiler/testdata/inline"
 		func Main() int {
 			values := []int{10, 11, 12}
 			for _, v := range values {
-				binary.Itoa(v, 10)


Again, it was here because it's returned value is dropped.

fyrchik · 2021-03-10T10:41:40Z

pkg/compiler/inline_test.go

 		import "github.com/nspcc-dev/neo-go/pkg/compiler/testdata/inline"
 		func Main() int {
 			sum := 0
 			values := []int{10, 11}
 			for _, v := range values {
-				binary.Itoa(v, 10)
-				sum += inline.VarSum(1, 2, 3, 4)
+				if v != 0 { // use 'v'


if creates another scope. We better just use e.g. _ = v.

AnnaShaleva · 2021-03-10T10:47:19Z

Why are last 2 commits in this PR?

They were in neo-modules#517 along with the changes related to this PR. Removed them.

roman-khimov

Looks like native contract coverage can be improved for erroneous cases.

pkg/interop/native/crypto/crypto.go

pkg/core/native/contract.go

pkg/core/native/std.go

pkg/core/notary_test.go

pkg/crypto/keys/private_key_test.go

pkg/interop/crypto/crypto.go

And move their tests to native StdLib.

roman-khimov · 2021-03-10T18:12:35Z

They were in neo-modules#517 along with the changes related to this PR.

Another PR for them?

pkg/crypto/keys/nep2_test.go

Koblitz RIP.

Rename it to Neo.Crypto.CheckMultisig and remove `message` parameter.

outdated

AnnaShaleva requested review from fyrchik and roman-khimov March 9, 2021 18:15

AnnaShaleva force-pushed the native/libs branch from 907ede9 to 25654b5 Compare March 9, 2021 18:16

AnnaShaleva mentioned this pull request Mar 10, 2021

Allow to dump public keys in CLI #1811

Merged

fyrchik previously requested changes Mar 10, 2021

View reviewed changes

AnnaShaleva force-pushed the native/libs branch from 623a5f5 to 2d86f5a Compare March 10, 2021 10:40

fyrchik reviewed Mar 10, 2021

View reviewed changes

AnnaShaleva force-pushed the native/libs branch from 2d86f5a to 87212d6 Compare March 10, 2021 10:45

AnnaShaleva force-pushed the native/libs branch 2 times, most recently from 413dbe7 to 75c65c3 Compare March 10, 2021 11:45

roman-khimov reviewed Mar 10, 2021

View reviewed changes

AnnaShaleva force-pushed the native/libs branch 2 times, most recently from 30e149e to e4ce23a Compare March 10, 2021 16:23

fyrchik and others added 8 commits March 10, 2021 19:24

native: implement CryptoLib contract

100f2db

compiler: fix contract.IsStandard syscall test

078870f

native: implement StdLib contract

2b90d44

core: remove System.Binary.Itoa and System.Binary.Atoi syscalls

f65485b

And move their tests to native StdLib.

core: remove System.Json.[Serialize, Deserialize] interops

4d2ad4b

And move their tests to native StdLib.

core: remove System.Binary.[Base64*, Base58*] syscalls

5c9c168

And move their tests to native StdLib.

core: remove System.Binary.[Serialize, Deserialize] syscalls

14ade42

And move their tests to native StdLib.

core: add Neo.Crypto.CheckSig interop

4e6c109

AnnaShaleva force-pushed the native/libs branch from e4ce23a to cbce17a Compare March 10, 2021 16:24

roman-khimov approved these changes Mar 10, 2021

View reviewed changes

pkg/crypto/keys/nep2_test.go Outdated Show resolved Hide resolved

roman-khimov requested a review from fyrchik March 10, 2021 18:22

AnnaShaleva added 3 commits March 10, 2021 21:45

core: use Neo.Crypto.CheckSig for standard signature verification

cdaca7b

core: remove Neo.Crypto.CheckMultisigWithECDsaSecp256k1

7126637

Koblitz RIP.

core: refactor Neo.Crypto.CheckMultisigWithECDsaSecpr1

9015e50

Rename it to Neo.Crypto.CheckMultisig and remove `message` parameter.

AnnaShaleva force-pushed the native/libs branch from cbce17a to 9015e50 Compare March 10, 2021 18:46

roman-khimov merged commit 5dff7af into master Mar 10, 2021

roman-khimov deleted the native/libs branch March 10, 2021 19:07

roman-khimov mentioned this pull request Mar 10, 2021

Split native method price into Cpu and Storage fees #1818

Merged

AnnaShaleva mentioned this pull request Mar 15, 2021

consensus: add MaxBlockSize and MaxBlockSysFee settings #1832

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

native: implement StdLib and CryptoLib contracts #1824

native: implement StdLib and CryptoLib contracts #1824

AnnaShaleva commented Mar 9, 2021 •

edited

Loading

codecov bot commented Mar 9, 2021 •

edited

Loading

fyrchik left a comment

fyrchik Mar 10, 2021

AnnaShaleva Mar 10, 2021

fyrchik Mar 10, 2021

fyrchik Mar 10, 2021

fyrchik Mar 10, 2021

fyrchik Mar 10, 2021

AnnaShaleva Mar 10, 2021

fyrchik Mar 10, 2021

fyrchik Mar 10, 2021

fyrchik Mar 10, 2021

fyrchik Mar 10, 2021

AnnaShaleva Mar 10, 2021

fyrchik Mar 10, 2021

fyrchik Mar 10, 2021

AnnaShaleva commented Mar 10, 2021

roman-khimov left a comment

roman-khimov commented Mar 10, 2021

native: implement StdLib and CryptoLib contracts #1824

native: implement StdLib and CryptoLib contracts #1824

Conversation

AnnaShaleva commented Mar 9, 2021 • edited Loading

codecov bot commented Mar 9, 2021 • edited Loading

Codecov Report

fyrchik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AnnaShaleva commented Mar 10, 2021

roman-khimov left a comment

Choose a reason for hiding this comment

roman-khimov commented Mar 10, 2021

AnnaShaleva commented Mar 9, 2021 •

edited

Loading

codecov bot commented Mar 9, 2021 •

edited

Loading