Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert boolean values in vm/emit #1822

Merged
merged 3 commits into from
Mar 9, 2021
Merged

Convert boolean values in vm/emit #1822

merged 3 commits into from
Mar 9, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Mar 9, 2021

Close #1821 .

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #1822 (5500915) into master (f087775) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1822      +/-   ##
==========================================
+ Coverage   83.54%   83.65%   +0.10%     
==========================================
  Files         272      272              
  Lines       21907    21907              
==========================================
+ Hits        18303    18326      +23     
+ Misses       2489     2465      -24     
- Partials     1115     1116       +1     
Impacted Files Coverage Δ
pkg/vm/emit/emit.go 100.00% <100.00%> (ø)
pkg/network/server.go 72.76% <0.00%> (+1.05%) ⬆️
pkg/services/oracle/request.go 62.29% <0.00%> (+4.91%) ⬆️
pkg/services/oracle/oracle.go 90.58% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f087775...5500915. Read the comment docs.

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refs. neo-project/neo-vm#330. CONVERT is pricy though...

@roman-khimov roman-khimov merged commit f35acff into master Mar 9, 2021
@roman-khimov roman-khimov deleted the fix/compilerequals branch March 9, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compiler: util.Equals bug (?)
3 participants