-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc, cli: allow to provide cosigners accounts to (*Client).CreateTxFromScript #1797
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1797 +/- ##
==========================================
+ Coverage 83.56% 83.66% +0.10%
==========================================
Files 271 271
Lines 22052 22077 +25
==========================================
+ Hits 18427 18471 +44
+ Misses 2500 2477 -23
- Partials 1125 1129 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also some CLI tests are needed (we already have verify contract in testdata, test wallet may need to be generated).
852daa9
to
c67e279
Compare
We already have |
adc326a
to
9b3376e
Compare
Can you rebase this on master to see if test failure is gone? |
Make cosigners non-variadic.
9b3376e
to
141b681
Compare
We need to define network fee for each of cosigners, and the only way to do it is to access the cosigner's script.
141b681
to
6c0faa4
Compare
We need cosigners' accounts to calculate the network fee properly.