Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc, cli: allow to provide cosigners accounts to (*Client).CreateTxFromScript #1797

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

AnnaShaleva
Copy link
Member

We need cosigners' accounts to calculate the network fee properly.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #1797 (6c0faa4) into master (4a9ca25) will increase coverage by 0.10%.
The diff coverage is 91.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1797      +/-   ##
==========================================
+ Coverage   83.56%   83.66%   +0.10%     
==========================================
  Files         271      271              
  Lines       22052    22077      +25     
==========================================
+ Hits        18427    18471      +44     
+ Misses       2500     2477      -23     
- Partials     1125     1129       +4     
Impacted Files Coverage Δ
pkg/rpc/client/rpc.go 84.21% <88.23%> (+0.52%) ⬆️
cli/smartcontract/smart_contract.go 87.88% <88.88%> (+0.16%) ⬆️
pkg/rpc/client/nep17.go 49.57% <90.00%> (+0.86%) ⬆️
cli/wallet/validator.go 73.33% <100.00%> (+1.45%) ⬆️
pkg/consensus/consensus.go 70.57% <0.00%> (+0.60%) ⬆️
pkg/services/oracle/request.go 62.29% <0.00%> (+4.91%) ⬆️
pkg/services/oracle/oracle.go 90.58% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a9ca25...6c0faa4. Read the comment docs.

Copy link
Contributor

@fyrchik fyrchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also some CLI tests are needed (we already have verify contract in testdata, test wallet may need to be generated).

cli/smartcontract/smart_contract.go Show resolved Hide resolved
@roman-khimov roman-khimov added this to the v0.94.0 milestone Mar 2, 2021
@AnnaShaleva AnnaShaleva force-pushed the rpc/fix-createtxfromscript branch 2 times, most recently from 852daa9 to c67e279 Compare March 3, 2021 07:47
@AnnaShaleva
Copy link
Member Author

Also some CLI tests are needed (we already have verify contract in testdata, test wallet may need to be generated).

We already have wallet1_solo.json and it suits the test perfectly. Done tests.

@fyrchik
Copy link
Contributor

fyrchik commented Mar 3, 2021

Can you rebase this on master to see if test failure is gone?

Make cosigners non-variadic.
@AnnaShaleva AnnaShaleva force-pushed the rpc/fix-createtxfromscript branch from 9b3376e to 141b681 Compare March 3, 2021 10:42
cli/contract_test.go Outdated Show resolved Hide resolved
We need to define network fee for each of cosigners, and the only way to
do it is to access the cosigner's script.
@AnnaShaleva AnnaShaleva force-pushed the rpc/fix-createtxfromscript branch from 141b681 to 6c0faa4 Compare March 4, 2021 07:37
@roman-khimov roman-khimov merged commit 0e7bb5c into master Mar 4, 2021
@roman-khimov roman-khimov deleted the rpc/fix-createtxfromscript branch March 4, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants