Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add go 1.16 support #1795

Merged
merged 1 commit into from
Mar 2, 2021
Merged

*: add go 1.16 support #1795

merged 1 commit into from
Mar 2, 2021

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva commented Mar 1, 2021

Close #1787.

Depends on nspcc-dev/dbft#52.

Benchmark results summary (average TPS):

Go 1.14 Go 1.15 Go 1.16
GoSingle 30 wrk 10597.374 10510.053 10697.590
GoFourNodes 30 work 1688.131 1954.547 1842.542

Benchmark results logs:

1_14_Go4x1_wrk_30.log
1_14_GoSingle_wrk_30.log
1_15_Go4x1_wrk_30.log
1_15_GoSingle_wrk_30.log
1_16_Go4x1_wrk_30.log
1_16_GoSingle_wrk_30.log

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #1795 (6626a7d) into master (10cc19b) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1795      +/-   ##
==========================================
+ Coverage   83.54%   83.62%   +0.08%     
==========================================
  Files         271      271              
  Lines       22026    22026              
==========================================
+ Hits        18401    18419      +18     
+ Misses       2500     2479      -21     
- Partials     1125     1128       +3     
Impacted Files Coverage Δ
pkg/rpc/client/wsclient.go 82.70% <0.00%> (+1.50%) ⬆️
pkg/services/oracle/request.go 62.29% <0.00%> (+4.91%) ⬆️
pkg/services/oracle/oracle.go 89.87% <0.00%> (+12.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10cc19b...cc112e1. Read the comment docs.

@roman-khimov
Copy link
Member

dbft probably needs to be updated after the merge. Fine otherwise.

@roman-khimov roman-khimov merged commit 5e91c6a into master Mar 2, 2021
@roman-khimov roman-khimov deleted the add-go-1-16 branch March 2, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Go 1.16 support
2 participants