rpc: detalize submit* RPC validation error
#1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1773 +/- ##
==========================================
- Coverage 83.52% 83.50% -0.02%
==========================================
Files 271 271
Lines 21986 21987 +1
==========================================
- Hits 18364 18361 -3
- Misses 2498 2501 +3
- Partials 1124 1125 +1
Continue to review full report at Codecov.
|
AnnaShaleva
force-pushed
the
detailed-rpc-error
branch
3 times, most recently
from
5054d69 to
29e0722
Compare
These changes do not break the compatibility with the C# node response. It is useful for the end-user to be aware of the failed validation reason. Also, the `cause` will be displayed at the running node log.
AnnaShaleva
force-pushed
the
detailed-rpc-error
branch
from
29e0722 to
2fbbade
Compare
roman-khimov
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes do not break the compatibility with the C# node response.
It is useful for the end-user to be aware of the failed validation reason.
Also, the
causewill be displayed at the running node log.