Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some Policy settings to config #1759

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Move some Policy settings to config #1759

merged 2 commits into from
Mar 4, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Feb 17, 2021

Close #1742 .

  1. MaxTransactionsPerBlock is moved to config.
  2. MaxBlockSize and MaxBlockSystemFee are removed. See also https://github.com/neo-project/neo/pull/2300/files#r571941755

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #1759 (ffd85dd) into master (924de3e) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1759      +/-   ##
==========================================
+ Coverage   83.54%   83.61%   +0.06%     
==========================================
  Files         273      273              
  Lines       22103    21980     -123     
==========================================
- Hits        18467    18379      -88     
+ Misses       2509     2478      -31     
+ Partials     1127     1123       -4     
Impacted Files Coverage Δ
pkg/consensus/consensus.go 68.55% <ø> (-2.02%) ⬇️
pkg/interop/native/policy/policy.go 0.00% <ø> (ø)
pkg/rpc/client/policy.go 62.16% <ø> (-1.95%) ⬇️
pkg/core/blockchain.go 77.82% <100.00%> (+0.08%) ⬆️
pkg/core/native/policy.go 86.78% <100.00%> (+0.79%) ⬆️
pkg/services/notary/notary.go 91.37% <0.00%> (-1.02%) ⬇️
pkg/services/oracle/request.go 62.29% <0.00%> (+4.91%) ⬆️
pkg/services/oracle/oracle.go 90.58% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 924de3e...ffd85dd. Read the comment docs.

pkg/core/blockchain.go Outdated Show resolved Hide resolved
@roman-khimov roman-khimov merged commit 39817aa into master Mar 4, 2021
@roman-khimov roman-khimov deleted the config/policy branch March 4, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move some settings from policy contract to configuration file
3 participants