network: add logs for different RelayTx errors #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyrchik
approved these changes
Feb 17, 2021
roman-khimov
requested changes
Feb 17, 2021
Codecov Report
@@ Coverage Diff @@
## master #1757 +/- ##
==========================================
+ Coverage 82.52% 82.65% +0.13%
==========================================
Files 272 271 -1
Lines 22152 22115 -37
==========================================
- Hits 18281 18280 -1
+ Misses 2745 2710 -35
+ Partials 1126 1125 -1
Continue to review full report at Codecov.
|
We don't need to wrap different core errors in server. Also it would be good to provede more error info to the user.
roman-khimov
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard to distinguish validation errors and users need more specific data.