Append bytes bigger than 0x79 properly #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1750 +/- ##
==========================================
+ Coverage 82.52% 82.55% +0.02%
==========================================
Files 272 272
Lines 22152 22177 +25
==========================================
+ Hits 18281 18308 +27
+ Misses 2745 2744 -1
+ Partials 1126 1125 -1
Continue to review full report at Codecov.
|
Like |
pkg/compiler/codegen.go
Outdated
| emit.Opcodes(c.prog.BinWriter, opcode.APPEND) | ||
| if expr.Ellipsis.IsValid() { | ||
| ast.Walk(c, expr.Args[1]) // append(x, y...) -> x, y on stack | ||
| emit.Opcodes(c.prog.BinWriter, opcode.DUP, opcode.REVERSEITEMS) // POPITEM pops last element |
There was a problem hiding this comment.
Fixed, inserted conversion to Struct, added test.
There was a problem hiding this comment.
REVERSEITEMS is quite costly and now we also CONVERT, maybe it's easier with PICKITEM?
NeoVM encoding for int(0x80) is []byte{0x80, 0x00} and
byte constant can be used both as integer and as an element
of byte-slice. Thus special case needs to be taken in
`append`.
NeoVM lacks opcode for array append, thus some kind of loop is needed for this.
roman-khimov
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1749 .
I works, but I am currently thinking how we can handle byte varargs in a more general way, including user-defined functions.