Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate NeoFS into oracle module #1484

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Integrate NeoFS into oracle module #1484

merged 1 commit into from
Mar 9, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Oct 13, 2020

Close #1473 .

pkg/oracle/neofs/neofs.go Outdated Show resolved Hide resolved
pkg/oracle/neofs/neofs.go Outdated Show resolved Hide resolved
pkg/oracle/neofs/neofs.go Outdated Show resolved Hide resolved
pkg/oracle/neofs/neofs.go Outdated Show resolved Hide resolved
pkg/oracle/neofs/neofs_test.go Outdated Show resolved Hide resolved
pkg/oracle/request.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #1484 (22b4edd) into master (f087775) will decrease coverage by 0.17%.
The diff coverage is 32.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1484      +/-   ##
==========================================
- Coverage   83.54%   83.37%   -0.18%     
==========================================
  Files         272      273       +1     
  Lines       21907    21995      +88     
==========================================
+ Hits        18303    18339      +36     
- Misses       2489     2543      +54     
+ Partials     1115     1113       -2     
Impacted Files Coverage Δ
pkg/services/oracle/request.go 51.51% <0.00%> (-5.87%) ⬇️
pkg/services/oracle/neofs/neofs.go 36.36% <36.36%> (ø)
pkg/vm/emit/emit.go 100.00% <0.00%> (ø)
pkg/consensus/consensus.go 69.18% <0.00%> (+0.62%) ⬆️
pkg/network/server.go 72.76% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f087775...22b4edd. Read the comment docs.

Base automatically changed from oracle/module to master January 28, 2021 12:24
@fyrchik
Copy link
Contributor Author

fyrchik commented Mar 9, 2021

Update:

  1. Made config compatible with C# node (we can replace single node with a list after Parsing array of string or single string go-yaml/yaml#100 or change C# node directly).
  2. Added tests for parsing routines.

@roman-khimov roman-khimov added this to the v0.94.0 milestone Mar 9, 2021
@roman-khimov roman-khimov merged commit 731adf8 into master Mar 9, 2021
@roman-khimov roman-khimov deleted the oracle/neofs branch March 9, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NeoFS integration into oracle module
3 participants