Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: decouple native contracts from interop service #1229

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva commented Jul 23, 2020

Closes #1191.

neo-project/neo#1655 won't be ported in this PR.

@AnnaShaleva AnnaShaleva self-assigned this Jul 23, 2020
@AnnaShaleva AnnaShaleva force-pushed the interop/native_call branch from 2c7fba3 to d7bd86e Compare July 24, 2020 06:03
@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #1229 into master will decrease coverage by 0.01%.
The diff coverage is 69.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1229      +/-   ##
==========================================
- Coverage   66.68%   66.66%   -0.02%     
==========================================
  Files         200      200              
  Lines       17184    17176       -8     
==========================================
- Hits        11459    11451       -8     
+ Misses       5112     5111       -1     
- Partials      613      614       +1     
Impacted Files Coverage Δ
pkg/core/interops.go 100.00% <ø> (ø)
pkg/core/native/contract.go 83.87% <ø> (+2.51%) ⬆️
pkg/core/native/native_nep5.go 71.02% <0.00%> (ø)
pkg/rpc/client/nep5.go 6.95% <ø> (ø)
pkg/rpc/client/policy.go 58.97% <ø> (ø)
pkg/core/native/interop.go 63.15% <64.00%> (+6.01%) ⬆️
pkg/core/interop/context.go 100.00% <100.00%> (ø)
pkg/core/native/native_gas.go 69.69% <100.00%> (-0.46%) ⬇️
pkg/core/native/native_neo.go 35.57% <100.00%> (-0.22%) ⬇️
pkg/core/native/policy.go 70.93% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf4481...83cd6e3. Read the comment docs.

@AnnaShaleva AnnaShaleva marked this pull request as ready for review July 28, 2020 08:05
Copy link
Contributor

@fyrchik fyrchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are also needed. There is already core/native_contract_test.go which can be extended.

@AnnaShaleva AnnaShaleva force-pushed the interop/native_call branch 3 times, most recently from 934c6a4 to 13f1b89 Compare July 28, 2020 11:29
@AnnaShaleva AnnaShaleva force-pushed the interop/native_call branch 2 times, most recently from 598f692 to e25a5b2 Compare July 29, 2020 07:09
@AnnaShaleva AnnaShaleva force-pushed the interop/native_call branch from e25a5b2 to 83cd6e3 Compare July 29, 2020 07:25
@AnnaShaleva AnnaShaleva force-pushed the interop/native_call branch from 83cd6e3 to 4bf88ba Compare July 29, 2020 07:33
@fyrchik fyrchik merged commit f24e707 into master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Neo.Native.Call syscall
2 participants