Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network magic check to NeoFSBlockFetcher #3644

Closed
AnnaShaleva opened this issue Oct 23, 2024 · 0 comments · Fixed by #3706
Closed

Add network magic check to NeoFSBlockFetcher #3644

AnnaShaleva opened this issue Oct 23, 2024 · 0 comments · Fixed by #3706
Assignees
@AliceInHunterland
Labels
enhancement Improving existing functionality feature Completely new functionality I4 No visible changes S4 Routine U3 Regular
Milestone
v0.107.0

Comments

@AnnaShaleva
Copy link
Member

After #3631 NeoFSBlockFetcher service missing a network magic check for the configured container, similar to the one implemented in c47d4e6.
@AnnaShaleva AnnaShaleva added feature Completely new functionality U3 Regular enhancement Improving existing functionality S4 Routine I4 No visible changes labels Oct 23, 2024
@AnnaShaleva AnnaShaleva added this to the v0.106.4 milestone Oct 23, 2024
@AliceInHunterland AliceInHunterland mentioned this issue Nov 26, 2024
Merged
AliceInHunterland added a commit that referenced this issue Nov 26, 2024
@AliceInHunterland
blockfetcher: check container and network Magic
ca5a0dc 
Close #3644

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Nov 27, 2024
@AliceInHunterland
blockfetcher: check container and network Magic
16842aa 
Close #3644

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Nov 27, 2024
@AliceInHunterland
blockfetcher: check container and network Magic
2861f3a 
Close #3644

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Nov 28, 2024
@AliceInHunterland
blockfetcher: check container and network Magic
7bbaf15 
Close #3644

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Nov 28, 2024
@AliceInHunterland
blockfetcher: check container and network Magic
4428c65 
Close #3644

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Nov 28, 2024
@AliceInHunterland
blockfetcher: check container and network Magic
debcb83 
Close #3644

Signed-off-by: Ekaterina Pavlova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliceInHunterland AliceInHunterland

Labels
enhancement Improving existing functionality feature Completely new functionality I4 No visible changes S4 Routine U3 Regular
Projects
None yet
Milestone
v0.107.0
Development

Successfully merging a pull request may close this issue.

NeoFS BlockFetcher: add pool with retries nspcc-dev/neo-go
2 participants
@AnnaShaleva @AliceInHunterland