Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit RPC notification subsystem filters against target structure types #3241

Closed
AnnaShaleva opened this issue Nov 29, 2023 · 2 comments · Fixed by #3258
Closed

Audit RPC notification subsystem filters against target structure types #3241

AnnaShaleva opened this issue Nov 29, 2023 · 2 comments · Fixed by #3258
Assignees
@AliceInHunterland
Labels
enhancement Improving existing functionality I3 Minimal impact S4 Routine U4 Nothing urgent
Milestone
v0.105.0

Comments

@AnnaShaleva
Copy link
Member

We need to ensure that all filters used to filter out RPC notifications have proper field types. E.g. BlockFilter has PrinaryIndex of int type while block.Block structure itself has PrimaryIndex of byte, and in this case we need to change filter's field type and all associated subscriptions logic.
@AnnaShaleva AnnaShaleva added the enhancement Improving existing functionality label Nov 29, 2023
@AnnaShaleva AnnaShaleva added this to the v0.105.0 milestone Nov 29, 2023
@roman-khimov
Copy link
Member

Primary index can't exceed ValidatorsCount in fact.

@AnnaShaleva
Copy link
Member Author

It's more like upper-level check, but it can also be implemented on the RPC server side. Maybe it's good idea to have some (*Fileter).IsValid() method to be implemented on every filter? We may include MaxEventNameLen restriction to contract notifications filter IsValid check then as far.

AliceInHunterland added a commit that referenced this issue Dec 9, 2023
@AliceInHunterland
rpc: blockFilter Primary field type change to byte
c0dfff9 
BlockFilter has PrinaryIndex of int type while block.Block structure
itself has PrimaryIndex of byte. It needs to prevent change filter's
field type and all associated subscriptions logic on server side.

Refs #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AliceInHunterland AliceInHunterland mentioned this issue Dec 9, 2023
Merged
AliceInHunterland added a commit that referenced this issue Dec 9, 2023
@AliceInHunterland
rpc: blockFilter Primary field type change to byte
d5f4325 
BlockFilter has PrinaryIndex of int type while block.Block structure
itself has PrimaryIndex of byte. It needs to prevent change filter's
field type and all associated subscriptions logic on server side.

Refs #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Dec 13, 2023
@AliceInHunterland
rpc: blockFilter Primary field type change to byte
2c647b2 
BlockFilter has PrinaryIndex of int type while block.Block structure
itself has PrimaryIndex of byte. It needs to prevent change filter's
field type and all associated subscriptions logic on server side.

Refs #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Dec 13, 2023
@AliceInHunterland
rpc: add filter IsValid functionality
04c5f2c 
Additional check of filters parameters added for filter validation.

Closes #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Dec 13, 2023
@AliceInHunterland
rpc: change the type of BlockFilter.Primary from int to byte
385c1d5 
BlockFilter has PrinaryIndex of int type while block.Block structure
itself has PrimaryIndex of byte. It's needed to prevent changing
filters field type and all associated subscriptions logic on
server side.

Refs #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Dec 13, 2023
@AliceInHunterland
neorpc: add WS notification filter IsValid functionality
3840e50 
Additional check of filters parameters added for filter validation.

Closes #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Dec 14, 2023
@AliceInHunterland
neorpc: add WS notification filter IsValid functionality
e12d38f 
Additional check of filters parameters added for filter validation.

Closes #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Dec 18, 2023
@AliceInHunterland
neorpc: add WS notification filter IsValid functionality
50e55c4 
Additional check of filters parameters added for filter validation.

Closes #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
@roman-khimov roman-khimov added I3 Minimal impact U4 Nothing urgent S4 Routine labels Dec 21, 2023
AliceInHunterland added a commit that referenced this issue Dec 22, 2023
@AliceInHunterland
neorpc: add WS notification filter IsValid functionality
c0c05d1 
Additional check of filters parameters added for filter validation.

Closes #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Dec 22, 2023
@AliceInHunterland
rpc: change the type of BlockFilter.Primary from int to byte
bec9def 
BlockFilter has PrinaryIndex of int type while block.Block structure
itself has PrimaryIndex of byte. It's needed to prevent changing
filters field type and all associated subscriptions logic on
server side.

Refs #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Dec 22, 2023
@AliceInHunterland
neorpc: add WS notification filter IsValid functionality
3e3bd5f 
Additional check of filters parameters added for filter validation.

Closes #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Dec 22, 2023
@AliceInHunterland
rpc: change the type of BlockFilter.Primary from int to byte
a8ff1eb 
BlockFilter has PrinaryIndex of int type while block.Block structure
itself has PrimaryIndex of byte. It's needed to prevent changing
filters field type and all associated subscriptions logic on
server side.

Refs #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Dec 22, 2023
@AliceInHunterland
neorpc: add WS notification filter IsValid functionality
b5b9af5 
Additional check of filters parameters added for filter validation.

Closes #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Dec 25, 2023
@AliceInHunterland
rpc: change the type of BlockFilter.Primary from int to byte
6b46663 
BlockFilter has PrinaryIndex of int type while block.Block structure
itself has PrimaryIndex of byte. It's needed to prevent changing
filters field type and all associated subscriptions logic on
server side.

Refs #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Dec 25, 2023
@AliceInHunterland
neorpc: add WS notification filter IsValid functionality
818f778 
Additional check of filters parameters added for filter validation.

Closes #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Dec 25, 2023
@AliceInHunterland
rpc: change the type of BlockFilter.Primary from int to byte
275e814 
BlockFilter has PrinaryIndex of int type while block.Block structure
itself has PrimaryIndex of byte. It's needed to prevent changing
filters field type and all associated subscriptions logic on
server side.

Refs #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Dec 25, 2023
@AliceInHunterland
neorpc: add WS notification filter IsValid functionality
1b7c76a 
Additional check of filters parameters added for filter validation.

Closes #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Dec 26, 2023
@AliceInHunterland
neorpc: add WS notification filter IsValid functionality
802006b 
Additional check of filters parameters added for filter validation.

Closes #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Dec 28, 2023
@AliceInHunterland
neorpc: add WS notification filter IsValid functionality
cc06674 
Additional check of filters parameters added for filter validation.

Closes #3241.

Signed-off-by: Ekaterina Pavlova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliceInHunterland AliceInHunterland

Labels
enhancement Improving existing functionality I3 Minimal impact S4 Routine U4 Nothing urgent
Projects
None yet
Milestone
v0.105.0
Development

Successfully merging a pull request may close this issue.

rpc: subscription filters validity check nspcc-dev/neo-go
3 participants
@roman-khimov @AnnaShaleva @AliceInHunterland