-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve KeepOnlyLatestState/RemoveUntraceableBlocks/P2PStateExchangeExtensions behaviour #2550
Labels
Comments
It's specific to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
We've got all the functionality needed, but I think we can improve the way users interact with it. There are two different worlds, public networks and private ones with P2PStateExchangeExtensions enabled and they have slightly different requirements. We can always strip all of the MPT data on non-P2PStateExchangeExtensions-enabled networks while we can't with this extensions enabled. The behavior we have now doesn't take P2PStateExchangeExtensions into account at all:
This true/true combination is where the main problem is. While it's appropriate for P2PStateExchangeExtensions=true (otherwise other nodes won't be able to synchronize and we technically can't keep just three MPTs, all intermediate ones must also be kept); it's not exactly the best thing for public networks. They can be slightly more aggressive and store just one MPT while removing all of the other data wrt the MaxTraceableBlocks setting. This will optimize the data stored significantly (we know MPT is a huge part of the overall data set).
But KeepOnlyLatestState=true with RemoveUntraceableBlocks=false combination can also be improved for P2PStateExchangeExtensions=true, we can store MaxTraceableBlocks number of MPTs while keeping any other data.
Related to #2152.
The text was updated successfully, but these errors were encountered: