Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: allow to handle GetMPTData command if KeepOnlyLatestState enabled #2152

Closed
AnnaShaleva opened this issue Sep 2, 2021 · 1 comment · Fixed by #2600
Closed

network: allow to handle GetMPTData command if KeepOnlyLatestState enabled #2152

AnnaShaleva opened this issue Sep 2, 2021 · 1 comment · Fixed by #2600
Assignees
Milestone

Comments

@AnnaShaleva
Copy link
Member

Depends on #2095.

We need to adjust server's handleGetMPTDataCmd behaviour wrt KeepOnlyLatestState setting. We also need a test for state exchange between two nodes with KeepOnlyLatestState on.

@AnnaShaleva AnnaShaleva changed the title insole: allow to handle MPT data if KeepOnlyLatestState enabled network: allow to handle GetMPTData command if KeepOnlyLatestState enabled Sep 2, 2021
@roman-khimov
Copy link
Member

At the moment KeepOnlyLatestState is ignored when RemoveUntraceable is active which kinda solves the problem (we have all the appropriate data). And and it's a fair behaviour to return whatever MPT data we have (if we don't, this command will error out anyway). So we can remove the check, but there are some other things that can be improved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants