-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbft: use previous block timestamp for view 0 initialization #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 74.45% 74.61% +0.15%
==========================================
Files 24 24
Lines 1296 1296
==========================================
+ Hits 965 967 +2
+ Misses 276 275 -1
+ Partials 55 54 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roman-khimov
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Oct 19, 2022
roman-khimov
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Oct 19, 2022
AnnaShaleva
reviewed
Oct 19, 2022
fyrchik
approved these changes
Oct 19, 2022
roman-khimov
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Oct 19, 2022
And always check new timestamp against it, timestamps can only move forward with each block.
roman-khimov
force-pushed
the
initialize-timestamp
branch
from
October 19, 2022 16:24
632ffe1
to
a69227c
Compare
AnnaShaleva
approved these changes
Oct 19, 2022
fyrchik
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And always check new timestamp against it, timestamps can only move forward with each block.