Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbft: use previous block timestamp for view 0 initialization #64

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

roman-khimov
Copy link
Member

And always check new timestamp against it, timestamps can only move forward with each block.

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #64 (a69227c) into master (c7e1bf4) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   74.45%   74.61%   +0.15%     
==========================================
  Files          24       24              
  Lines        1296     1296              
==========================================
+ Hits          965      967       +2     
+ Misses        276      275       -1     
+ Partials       55       54       -1     
Impacted Files Coverage Δ
check.go 92.85% <100.00%> (ø)
context.go 84.95% <100.00%> (+1.76%) ⬆️
dbft.go 67.77% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

check.go Outdated Show resolved Hide resolved
context.go Outdated Show resolved Hide resolved
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Oct 19, 2022
And always check new timestamp against it, timestamps can only move forward
with each block.
@roman-khimov roman-khimov merged commit 31c1bbd into master Oct 20, 2022
@roman-khimov roman-khimov deleted the initialize-timestamp branch October 20, 2022 09:34
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants