context: correctly save previous change view payloads during view reset #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're used to create recovery messages and currently we're completely missing CV payloads there because of this logic. In fact we want to save messages that lead to the current view we're resetting the state for (==), but newer ones don't hurt also (>=), even though we shouldn't have them. See C# implementation.
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 73.75% 73.98% +0.23%
==========================================
Files 24 24
Lines 1303 1303
==========================================
+ Hits 961 964 +3
+ Misses 285 284 -1
+ Partials 57 55 -2
Continue to review full report at Codecov.
|
fyrchik
approved these changes
Jun 29, 2022
AnnaShaleva
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're used to create recovery messages and currently we're completely
missing CV payloads there because of this logic. In fact we want to save
messages that lead to the current view we're resetting the state for (==), but
newer ones don't hurt also (>=), even though we shouldn't have them. See C#
implementation.